Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup unnecessary use of json() property #148

Closed
sserrata opened this issue Apr 2, 2020 · 0 comments · Fixed by #150
Closed

Cleanup unnecessary use of json() property #148

sserrata opened this issue Apr 2, 2020 · 0 comments · Fixed by #150
Assignees
@sserrata
Labels
bug Something isn't working

Comments

@sserrata
Copy link
Member

sserrata commented Apr 2, 2020

Describe the bug

The requests json() property is used (rather irresponsibly) throughout the library.

Expected behavior

The json() property should only be called when necessary.

Current behavior

See description.

Possible solution

Reduce the number of times json() is called. One simple approach is to assign the output to a variable that can be reused within its scope.

Steps to reproduce

n/a

Screenshots

Context

Your Environment

  • Version used: alpha8
  • Environment name and version (e.g. Chrome 59, node.js 5.4, python 3.7.3):
  • Operating System and version (desktop or mobile):
  • Link to your project:
@sserrata sserrata added the bug Something isn't working label Apr 2, 2020
@sserrata sserrata self-assigned this Apr 2, 2020
sserrata added a commit to sserrata/pan-cortex-data-lake-python that referenced this issue Apr 3, 2020
@sserrata
Reduce number of times json() property is called, fixes PaloAltoNetwo…
8243ec5 
…rks#148
@sserrata sserrata mentioned this issue Apr 3, 2020
Merged
4 tasks
sserrata added a commit that referenced this issue Apr 3, 2020
@sserrata
Alpha9 (#150)
d3709b3 
* Update clientType and clientVersion, fixes #149

* Reduce number of times json() property is called, fixes #148

* Check if static access_token exists before developer token refresh, fixes #147

* Bump version to alpha9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sserrata sserrata

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Alpha9 sserrata/pan-cortex-data-lake-python
1 participant
@sserrata