JIT Valset update for all jobs #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we published a JIT valset update only for jobs that were triggered using the scheduling module. Bots and other contract triggering job authors would simply bypass this. This change adds a JIT valset update to any job, no matter the triggering call path.
byte-bandit
changed the title
|
Drafting this to block merge until I resolve contract deployment issues due to the new erc20 ownership transfer. |
|
addding the id will be very helpful, thanks |
verabehr
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Github tickets
Background
Previously, we published a JIT valset update only for jobs
that were triggered using the scheduling module. Bots
and other contract triggering job authors would simply
bypass this.
This change adds a JIT valset update to any job, no matter
the triggering call path.
It also includes an improvement to return with the ID of the
consensus message that was created upon executing a job.
This information will be stored as part of the TX, giving us a
full link into which TX lead to which message being triggered.
Testing completed
Breaking changes