Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freighter-api 1.7.1 adaptation TESTED #52

Merged
merged 5 commits into from
Oct 25, 2023
Merged

freighter-api 1.7.1 adaptation TESTED #52

merged 5 commits into from
Oct 25, 2023

Conversation

benjaminsalon
Copy link
Collaborator

No description provided.

@esteblock
Copy link
Member

Please add the error if sorobanRpc is not set
And test this with the multichain dapp

@benjaminsalon
Copy link
Collaborator Author

Test with multichain dapp is passing!

@benjaminsalon benjaminsalon changed the title freighter-api 1.7.1 adaptation NON TESTED freighter-api 1.7.1 adaptation TESTED Oct 23, 2023
@benjaminsalon benjaminsalon marked this pull request as ready for review October 23, 2023 14:45
This was linked to issues Oct 23, 2023
Freighter-api is switching horizon/soroban rpc #47
Closed
If the wallet does not provide a SorobanRpcUrl we should handle the error #51
Open
@benjaminsalon benjaminsalon mentioned this pull request Oct 24, 2023
Open
@benjaminsalon benjaminsalon merged commit ccdddf6 into main Oct 25, 2023
2 checks passed
@benjaminsalon benjaminsalon deleted the freighter-api-rpc-url-handling branch October 25, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@benjaminsalon @esteblock