Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option soa_edit_api #40

Merged
merged 3 commits into from
Nov 12, 2019
Merged

add option soa_edit_api #40

merged 3 commits into from
Nov 12, 2019

Conversation

splashx
Copy link
Contributor

@splashx splashx commented Nov 7, 2019 •
edited

Feature:

  • Add support for soa_edit_api argument in the zone resource. The argument is optional and doesn't introduce breaking change. Closes add option soa_edit_api #40

Minor:

  • Tests: Adds a new zone for SOA Record testing. With introduction of parallel tests, deleting the SOA record (during SOA Record test) will make the other record tests to fail.

@splashx splashx requested a review from mbag November 7, 2019 13:25
mbag
mbag requested changes Nov 12, 2019
View reviewed changes
powerdns/client.go Outdated Show resolved Hide resolved
@mbag mbag merged commit 5906ad8 into pan-net:master Nov 12, 2019
@splashx splashx mentioned this pull request Nov 25, 2019
Closed
@c33s c33s mentioned this pull request Dec 21, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbag mbag mbag requested changes

Assignees

@mbag mbag

Labels
documentation size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@splashx @mbag