fixed babel#4632 - missing parentheses around yield expression … (bab…

…el#4633) * fixed babel#4632 - missing parentheses around yield expression in conditional test * babel#4632 - added test
panagosg7 · Jan 17, 2017 · f5e73ef · f5e73ef
1 parent 6b0358e
commit f5e73ef
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/packages/babel-generator/src/node/parentheses.js b/packages/babel-generator/src/node/parentheses.js
@@ -142,7 +142,9 @@ export function YieldExpression(node: Object, parent: Object): boolean {
          t.isUnaryLike(parent) ||
          t.isCallExpression(parent) ||
          t.isMemberExpression(parent) ||
-         t.isNewExpression(parent);
+         t.isNewExpression(parent) ||
+         (t.isConditionalExpression(parent) && node === parent.test);
+
 }
 
 export { YieldExpression as AwaitExpression };

diff --git a/packages/babel-generator/test/fixtures/parentheses/yield-expression/actual.js b/packages/babel-generator/test/fixtures/parentheses/yield-expression/actual.js
@@ -2,7 +2,7 @@ function* asdf() {
   (yield 1) || (yield 2);
   (yield b)();
   new (yield b)();
-  true ? (yield 1) : (yield 2);
+  (yield 1) ? (yield 2) : (yield 3);
   yield (yield 1);
 }
 

diff --git a/packages/babel-generator/test/fixtures/parentheses/yield-expression/expected.js b/packages/babel-generator/test/fixtures/parentheses/yield-expression/expected.js
@@ -2,7 +2,7 @@ function* asdf() {
   (yield 1) || (yield 2);
   (yield b)();
   new (yield b)();
-  true ? yield 1 : yield 2;
+  (yield 1) ? yield 2 : yield 3;
   yield yield 1;
 }