Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore GitHub action files #53

Merged
merged 1 commit into from
Jan 4, 2022
Merged

ignore GitHub action files #53

merged 1 commit into from
Jan 4, 2022

Conversation

rene-d
Copy link
Contributor

@rene-d rene-d commented Jan 3, 2022

When syncing the crates.io-index, the GitHub action file update-dl-url.ymlis present in the Git mirror and will not be filtered out like config.json. It fails to be deserialized at line

let c: CrateEntry = serde_json::from_str(&line).unwrap();
and panamax panics:

Syncing Crates repositories...
[1/3] Fetching crates.io-index...
[2/3] Syncing crates files...
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error("invalid number", line: 1, column: 2)', src/crates.rs:170:65
[2/3] Syncing crates files...

Now, paths that start with '.github/' will be skipped and the JSON deserialization should not stop the program if it fails.

@k3d3
Copy link
Member

k3d3 commented Jan 4, 2022

Oh wow, nice catch!

This looks like a good enough solution, ignoring files that can't be deserialized. Thanks!

@k3d3 k3d3 merged commit 0b169b0 into panamax-rs:master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants