Fix Docker Image Failing to Sync #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for the docker image to sync and serve packages correctly. Without it panamax will not download most of the crates and will throw 500 errors.
Since the image's state is mounted into the container setting the container to auto delete when it's process exits helps cut down on the number of stopped images.
See issue panamax-rs#61 panamax-rs#61 The command `cargo install panamax` fails because it doesn't default to using locked files.
|
Looks good to me, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current panamax docker image if failing to sync most crates, because it is missing git.
This MR adds git to the dockerfile to fix this.
Resolves #51
Also updated the readme which should resolve #61