Skip to content

Commit

Permalink
[SPARK-40732][SQL][TESTS] Make (SQL|ThriftServer)QueryTestSuite pas…
Browse files Browse the repository at this point in the history
…s except Pandas UDF tests in Java 21

### What changes were proposed in this pull request?

This PR aims to make `SQLQueryTestSuite` and `ThriftServerQueryTestSuite` pass except Pandas UDF tests in Java 21.

### Why are the changes needed?

Two Java bug fixes changed the behavior and we need a new test output for those test cases.
- JDK-4511638 changes 'toString' result of Float/Double
- JDK-8282081 changes DataTimeFormatter 'F' symbol

In addition, `Apache Arrow` doesn't support Java 21 until now. So, I excluded it with TODO JIRA, SPARK-44097 in Java 21 environment.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs and do manual test on Java 21.

```
$ java -version
openjdk version "21-ea" 2023-09-19
OpenJDK Runtime Environment (build 21-ea+27-2343)
OpenJDK 64-Bit Server VM (build 21-ea+27-2343, mixed mode, sharing)
```

```
$ build/sbt "sql/testOnly *.SQLQueryTestSuite"
...
[info] Run completed in 8 minutes, 41 seconds.
[info] Total number of tests run: 560
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 560, failed 0, canceled 0, ignored 59, pending 0
[info] All tests passed.
[success] Total time: 683 s (11:23), completed Jun 19, 2023, 1:24:34 AM
```

```
$ build/sbt "hive-thriftserver/testOnly *.ThriftServerQueryTestSuite" -Phive-thriftserver
...
[info] Run completed in 6 minutes, 14 seconds.
[info] Total number of tests run: 211
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 211, failed 0, canceled 0, ignored 19, pending 0
[info] All tests passed.
[success] Total time: 396 s (06:36), completed Jun 19, 2023, 1:43:44 AM
```

Closes apache#41658 from dongjoon-hyun/SPARK-40732.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
  • Loading branch information
dongjoon-hyun committed Jun 19, 2023
1 parent 6c0c226 commit 1008d64
Show file tree
Hide file tree
Showing 11 changed files with 8,470 additions and 4 deletions.
1 change: 1 addition & 0 deletions dev/.rat-excludes
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ db.lck
build/*
dist/*
.*out
.*out.java21
.*ipr
.*iws
logs
Expand Down
Loading

0 comments on commit 1008d64

Please sign in to comment.