Table component on /farms page #336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: add defaultProps for Cell component
…ke-frontend into table-update
RabbitDoge
reviewed
Feb 1, 2021
RabbitDoge
reviewed
Feb 1, 2021
RabbitDoge
reviewed
Feb 1, 2021
hachiojidev
suggested changes
Feb 15, 2021
RabbitDoge
reviewed
Feb 16, 2021
| } | ||
|
|
||
| return ( | ||
| <> |
There was a problem hiding this comment.
you don't need a fragment here
RabbitDoge
reviewed
Feb 16, 2021
|
|
||
| useEffect(() => { | ||
| if (scrollBarEl && scrollBarEl.current) { | ||
| let isScrolling1 = false |
There was a problem hiding this comment.
this is probably the worst naming you can use for a variable. Someone who doesn't know you code should be able to understand what a variable contains just by reading the name
* fix(nft): Claim status response * chore: Formatting * refactor: Moved window variable at top of file * chore: Fix type * refactor: Get address chain Id source
* fix: Add getter to access BinanceChain at runtime * chore: Add comment
|
Work migrated to #482 |
chef-jojo
added a commit
to chef-jojo/pancake-frontend
that referenced
this pull request
Jan 25, 2022
…ice (pancakeswap#336) * fix(uikit): Menu position incorrect and link no response on touch device * test(uikit): Update snapshot * chore(uikit): Update naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add farms table to farms dashboard.
Dependency:
pancakeswap/pancake-uikit#165
This pull request requires this change.