New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pair seems to be saved twice in `handleSwap` #52

Open

maoueh opened this issue May 14, 2021 · 2 comments

maoueh commented May 14, 2021 •

edited

Loading

This line:

pancake-subgraph/src/exchange/core.ts

Line 409 in a84f478

pair.save();

Is already performed few lines above:

pancake-subgraph/src/exchange/core.ts

Line 399 in a84f478

pair.save();

This feels superfluous, since it's done 10 lines above and nothing change in between.

Author

maoueh commented May 14, 2021

While at it,

pancake-subgraph/src/exchange/core.ts

Line 430 in a84f478

swap.transaction = transaction.id;

also is duplicated with

pancake-subgraph/src/exchange/core.ts

Line 427 in a84f478

swap.transaction = transaction.id;

Contributor

ChefKai commented May 26, 2021

Thank you for opening an issue; as we weren't able to deploy a subgraph for a long time, we haven't been able to deep-dive on the exchange subgraph for a while. We will start improving it soon, based on performance upgrade done on exchange-lite!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment