Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TTL option to DriftClient.walk method #38

Merged
merged 5 commits into from
Dec 14, 2023
Merged

Add TTL option to DriftClient.walk method #38

merged 5 commits into from
Dec 14, 2023

Conversation

atimin
Copy link
Member

@atimin atimin commented Dec 14, 2023

Closes #

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CHANGELOG.md have been updated (for bug fixes / features / docs)

What kind of change does this PR introduce?

Feature

What is the current behavior?

The TTL of the data query is hand coded as 60 seconds. Sometimes it is too little. A user should be able to change it.

What is the new behavior?

I've add the option to DriftClient.walk as an optional parameter.

Does this PR introduce a breaking change?

No

Other information:

@atimin atimin merged commit 04d2929 into develop Dec 14, 2023
2 checks passed
@atimin atimin deleted the add-ttl-option branch December 14, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant