Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIFT-516: Replace get_list by get_topic_data #5

Merged
merged 4 commits into from
Aug 11, 2022
Merged

DRIFT-516: Replace get_list by get_topic_data #5

merged 4 commits into from
Aug 11, 2022

Conversation

EkaterinaPocherevina
Copy link
Contributor

Closes #

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CHANGELOG.md have been updated (for bug fixes / features / docs)

What kind of change does this PR introduce?

Feature

What is the current behavior?

You can get history data, using list of string timestamps

What is the new behavior?

You can get history data, using start and stop timestamps in different formats (datetime, iso string and float)

Does this PR introduce a breaking change?**

No

Other information:

pkg/drift_client/drift_client.py Outdated Show resolved Hide resolved
pkg/drift_client/drift_client.py Outdated Show resolved Hide resolved
pkg/drift_client/drift_client.py Outdated Show resolved Hide resolved
pkg/drift_client/drift_client.py Outdated Show resolved Hide resolved
tests/drift_client_test.py Outdated Show resolved Hide resolved
@atimin atimin merged commit 5299566 into develop Aug 11, 2022
@atimin atimin deleted the drift-516 branch August 11, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants