Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilationerrors after injecting bugs using function args #6

Closed
horlabs opened this issue Oct 16, 2018 · 2 comments
Closed

Compilationerrors after injecting bugs using function args #6

horlabs opened this issue Oct 16, 2018 · 2 comments

Comments

@horlabs
Copy link
Contributor

horlabs commented Oct 16, 2018

Hey,
when I tried to compile the file-program ("example"/default in the init-script) with bugs, I got many errors if the scripts using function args to inject the bugs. Because of the new args there are several errors in attribute(format(printf, x, y) (new argument for this function, but x and y weren't actualized) and function prototypes inside a c-file weren't changed either.

Using globals instead of function args works fine.

@moyix
Copy link
Contributor

moyix commented Oct 17, 2018

Yes, the implementation of data flow through arguments is somewhat flaky in this version. We have updates that make it more reliable that we are hoping to push to here pretty soon.

@AndrewFasano
Copy link
Member

This is now fixed for the provided File target through pre-processing and removing the attributes. We've described the process for doing this in our documentation on adding new targets.

That said, this isn't a great solution. We could instead do something where we rewrite attributes for the functions we're adding data_flow to, but this might only work for a subset of possible attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants