Bump capstone version + aarch64 support in callstack_instr #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewFasano
force-pushed
the
callstack_instr
branch
from
697f021
to
abba039
Compare
If capstone versions is between 4 and 5 use a fallback method, otherwise use the provided groups as normal.
AndrewFasano
force-pushed
the
callstack_instr
branch
from
abba039
to
67f1a51
Compare
AndrewFasano
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously aarch64 was hitting arm32 code and failing to identify any calls and returns. this PR updates that plugin to support aarch64 and also bumps the capstone version as our prior version failed to properly identify call/return groups for aarch64.
Adds a simple pypanda test for callstack instr.
Also has a commit dropping a needless call to
cargo helpwhile building the docker container.