Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass built-in array shader inputs in one go #883

Closed
rdb opened this issue Mar 19, 2020 · 0 comments
Closed

Pass built-in array shader inputs in one go #883

rdb opened this issue Mar 19, 2020 · 0 comments
Assignees
Milestone

Comments

@rdb
Copy link
Member

rdb commented Mar 19, 2020

The value for the built-in shader input matrix p3d_TextureMatrix[] is currently specified separately for each element, by incrementing the location index for each array item. As discovered in #846, however, older OpenGL versions do not appear to guarantee that successive elements in uniform arrays use consecutive location indices, and indeed Apple doesn't do this.

There is a hack in place to make this work, but it would be better if the built-in shader input passing system were instead designed to be able to pass in the whole array in one go.

The built-in shader input passing system is very arcane, so it might be worth doing a significant redesign, especially with support for uniform buffers in mind.

@rdb rdb self-assigned this Jul 27, 2023
@rdb rdb added this to the 1.11.0 milestone Jul 27, 2023
@rdb rdb added the opengl label Jul 27, 2023
@rdb rdb closed this as completed in cb4597e Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants