No results for all dataset queries in Firefox

[mthatcherclark]

I've tried this on four different computers and two installations of Panda. When I use Firefox 15 to search all datasets with a query that has spaces in it, I get no results (even though I know there should be results). Doesn't seem to do it with single dataset searches. Sometimes, it won't do it later in the session, but it always does it when I first arrive at the landing page.

I fiddled around a little with the Panda on a laptop I have and discovered that Firefox seems to submit the query twice to the "search_all_data" function in data.py. The first time without the %20s and second time with them. I notice when I query that the results flash for a brief second before it tells me that there are no results. What a tease!

Unfortunately, I'm not familiar with all the Javascript usage in Panda. I did a quick, temporary solution with Python's string replace method. Hoping someone can help out. Cheers.

On a side note, this is the first time I have ever submitted a bug.

[mthatcherclark]

Just realized that it will also do this with asterisks and other search terms that need to be escaped. I believe the way Firefox is interpreting the javascript is causing the query to be submitted twice, once without the escaped characters and the second time with them (because the search box has the phrase with the %20s in it the second time it is submitted).

[onyxfish]

Hi Matt. It's horrible that I'm just now replying to a three month old ticket, but PANDA hasn't gotten much attention since full-time development stopped. I'm back now on contract to code some bug fixes so I wanted to thank you for the bug report and let you know I've slotted this as high priority. Thanks!

[mthatcherclark]

Great to hear, Chris. Absolutely no worries. I think folks in the newsroom here are thrilled with Panda, and we came up with a temporary fix that just replaces the "%20s" with quotes when the form is submitted the second time. Kept telling myself I would learn the crazy cool javascript in order to figure out what was going on, but never did. Thanks again for your help!

[onyxfish]

This turns out to be a very subtle, Firefox-specific bug related to how the browser encodes url components. The issue is documented in these two Backbone tickets:

jashkenas/backbone#1156
jashkenas/backbone#1219

Currently experimenting with a work-around.