ENH: Synchronize io/stata with pandas master #202
Conversation
|
No tests yet, but can do some here |
| columns: list[HashableT] | None = ..., | ||
| order_categoricals: bool = ..., | ||
| chunksize: int | None = ..., | ||
| *, |
There was a problem hiding this comment.
so the second and third overload only different in whether the arguments are keyword-only or can also be provided as positional arguments?
If pandas would have deprecated positional arguments, I would remove the positional overloads - but they are not yet deprecated. (Will try to open a PR for that later today at pandas.)
There was a problem hiding this comment.
Yup. They are needed to handle the cases where iterator=True either using a keyword argument or only positional.
There was a problem hiding this comment.
I opened pandas-dev/pandas#48128 to make most arguments keyword-only
There was a problem hiding this comment.
using positional keywords will now be deprecated in 1.5 (except for the first non-self argument)
Sychronize and remvoe classes not part of the public API
|
Test added. I took the CM from pandas. It could be made available somewhere else, or we could stub it in even though it is not public. |
pandas-stubs/core/frame.pyi
Outdated
| path: FilePathOrBuffer, | ||
| convert_dates: dict | None = ..., | ||
| path: FilePath | WriteBuffer[bytes], | ||
| convert_dates: dict[Hashable, str] | None = ..., |
There was a problem hiding this comment.
Looking at the code, only values for str are [ "tc", "%tc", "td", "%td", "tw", "%tw", "tm", "%tm", "tq", "%tq", "th", "%th", "ty", "%ty", ]
Add literals for limited value inputs
pandas-stubs/io/stata.pyi
Outdated
| ) -> None: ... | ||
| def generate_table(self) -> tuple[dict[str, tuple[int, int]], DataFrame]: ... | ||
| def generate_blob(self, gso_table: dict[str, tuple[int, int]]) -> bytes: ... | ||
|
|
||
| class StataWriter117(StataWriter): |
There was a problem hiding this comment.
StataWriter117 is not public, so we can delete
pandas-stubs/io/stata.pyi
Outdated
| convert_strl: Sequence[Hashable] | None = ..., | ||
| compression: CompressionOptions = ..., | ||
| storage_options: StorageOptions = ..., | ||
| *, | ||
| value_labels: dict[Hashable, dict[float, str]] | None = ..., | ||
| value_labels: dict[HashableT, dict[float, str]] | None = ..., | ||
| ) -> None: ... | ||
|
|
||
| class StataWriterUTF8(StataWriter117): |
There was a problem hiding this comment.
StataWriterUTF8 is not public, so we can delete
Sychronize and remvoe classes not part of the public API
assert_type()to assert the type of any return value