upgrade SQLAlchemy and pyright #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
reviewed
May 7, 2023
| @@ -1095,6 +1095,7 @@ def test_read_sql_via_sqlalchemy_connection(): | |||
| assert_type(read_sql("select * from test", con=conn), DataFrame), | |||
| DataFrame, | |||
| ) | |||
| engine.dispose() | |||
There was a problem hiding this comment.
Can engine be used as a context manager? Might be slightly nicer if that's possible
There was a problem hiding this comment.
No, it is not possible.
twoertwein
reviewed
May 7, 2023
| | sqlalchemy.sql.expression.Selectable | ||
| | sqlalchemy.sql.expression.TextClause | ||
| | sqlalchemy.sql.Select | ||
| | FromStatement |
There was a problem hiding this comment.
Do we need to add those libraries (or their stubs) as a dependency?
There was a problem hiding this comment.
I don't think so. I just added the two new types that seem to be valid for the test we had. We have sqlalchemy in our dev environment, but we don't want to make it something you have to install to use the stubs.
twoertwein
approved these changes
May 8, 2023
|
Thanks @Dr-Irv ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on pandas-dev/pandas#50558 (comment), we could upgrade SqlAlchemy to 2.0. Doing that revealed an issue in those tests and some of the typing.
Also bumped pyright to 1.1.306, but the default value for
useLibraryCodeForTypeschanged in that version, so added that inpyproject.toml. Without that, some of the plotting tests fail becausematplotlibdoesn't have typing yet.