TYP: Add DatetimeIndex.intersection() method and test #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Irv
requested changes
Jul 17, 2023
Dr-Irv
requested changes
Jul 17, 2023
| @@ -97,6 +97,7 @@ class DatetimeIndex( # type: ignore[misc] | |||
| def tzinfo(self) -> tzinfo | None: ... | |||
| @property | |||
| def dtype(self) -> np.dtype | DatetimeTZDtype: ... | |||
| def intersection(self, other: DatetimeIndex | list) -> DatetimeIndex: ... | |||
There was a problem hiding this comment.
list is too broad. I think Sequence[DatetimeLike] will work where you import DatetimeLike from pandas._typing
|
|
||
| result = idx1.intersection(idx2) | ||
|
|
||
| check(assert_type(result, pd.DatetimeIndex), pd.DatetimeIndex) |
There was a problem hiding this comment.
If you include the list[DatetimeLike] as I suggested, then you should include tests that do intersection() with lists of those 3 different types. E.g., idx1.intersection([pd.Timestamp(x) for x in idx2]) and something similar for dt.datetime and np.datetime64
|
Also, you are failing in CI because of one (or both) of two reasons:
|
|
@Dr-Irv Thank you for the feedback! I will try to have a better version of this up by the weekend or early next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix DatetimeIndex.intersection() return type
The return type of DatetimeIndex.intersection() was incorrectly
specified.This updates the method signature to indicate the correct return
type of DatetimeIndex.
Test added as well.
Fixes #744
assert_type()to assert the type of any return value