Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace flake8 and pyupgrade with ruff #754

Merged
merged 8 commits into from
Jul 25, 2023
Merged

Conversation

twoertwein
Copy link
Member

Pandas switched to ruff a while ago: ruff is much faster and combines many different tools (including flake8-pyi and pyupgrade).

ruff fails currently because of this line which looks a bit weird:

class Styler(StylerRenderer[Styler]):

@twoertwein twoertwein requested a review from Dr-Irv July 20, 2023 14:52
scripts/test/run.py Outdated Show resolved Hide resolved
pandas-stubs/core/indexes/accessors.pyi Outdated Show resolved Hide resolved
scripts/test/run.py Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @twoertwein

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Jul 25, 2023

@twoertwein So I thanked you for this, then forgot to merge, and now there is a conflict. Can you resolve that conflict and push again?

@twoertwein
Copy link
Member Author

Sorry, did git pull --rebase upstream main which then required a force push.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @twoertwein

@Dr-Irv Dr-Irv merged commit 6769e81 into pandas-dev:main Jul 25, 2023
13 checks passed
@twoertwein twoertwein deleted the ruff branch August 14, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants