Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #777 #778

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Fix #777 #778

merged 1 commit into from
Sep 18, 2023

Conversation

twoertwein
Copy link
Member

twoertwein
twoertwein commented Sep 18, 2023
View reviewed changes
pandas-stubs/plotting/_core.pyi
self,
x: Hashable | None = ...,
y: Hashable | None = ...,
x: Hashable = ...,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None is Hashable

Dr-Irv
Dr-Irv approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @twoertwein

@Dr-Irv Dr-Irv merged commit 1411742 into pandas-dev:main Sep 18, 2023
10 checks passed
@twoertwein twoertwein deleted the overloads branch February 10, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Irv Dr-Irv Dr-Irv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix overloads in plotting/_core.pyi
2 participants
@twoertwein @Dr-Irv