Fix calling df.agg with scalar dict values #861
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataFrame.agg()
can returnSeries
orDataFrame
withdict
argument #846assert_type()
to assert the type of any return valueAs promised in #846 (comment)
The overlap in overloads is necessary as a dict with only scalar values returns a series but a dict with lists and optionally scalar values returns a dataframe. So both overloads have to accept scalar values but that doesn't seem to be a problem as both mypy and pyright are able to infer the good overload.