CI: fix nightly #869
Merged
CI: fix nightly #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Irv
requested changes
Feb 13, 2024
tests/test_io.py
Outdated
Comment on lines
431
to
437
| if PD_LTE_22: | ||
| path = Path(CWD, "data", "labelled-num.sav") | ||
| with pytest_warns_bounded( | ||
| FutureWarning, | ||
| "ChainedAssignmentError: behaviour will change", | ||
| lower="2.1.99", | ||
| ): |
There was a problem hiding this comment.
I think we need to do this test on nightly, but make the error message dependent on the version. For version 2.2, the message is "ChainedAssignmentError: behaviour will change" . For nightly, it is "ChainedAssignmentError: A value is trying to be set on"
So let's keep the test, and just make the message that is checked based on PD_LTE_22
There is an issue about this: pandas-dev/pandas#51315
There was a problem hiding this comment.
Changed! There were a few new errors on nightly (finally removed support for "ignore")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return value