896 dataframe from dict columns dtype args #897
Conversation
|
I have added in f760452 new test and overload to cover when |
Let me know when I should do another review. |
|
@Dr-Irv please proceed, tests on my computer just finished successfully |
pandas-stubs/core/frame.pyi
Outdated
| @overload | ||
| @classmethod | ||
| def from_dict( | ||
| cls, | ||
| data: dict[Any, Any], | ||
| orient: Literal["columns", "index", "tight"] = ..., | ||
| dtype: _str = ..., | ||
| columns: list[_str] = ..., | ||
| orient: str, | ||
| dtype: AstypeArg | None = ..., |
There was a problem hiding this comment.
This should be removed. We only want to match the first or second overload. This would match any string for orient.
tests/test_frame.py
Outdated
| # check when not using Literal | ||
| orient_str = "index" |
There was a problem hiding this comment.
With the change I suggested above to remove the orient: str, the test below may fail. But that's OK - in this case the type checker isn't inferring that doing orient = "index" matches Literal["index"] . I'm pretty sure that pyright does that inference - not sure about mypy.
So if you make that change, and this test below fails, you can remove the test.
There was a problem hiding this comment.
This test does fail with mypy.
I'll revert my last commit to suppress the last overload and failing tests
This reverts commit f760452.
test_frame.test_types_from_dict