-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPR: filter & select #12401
Comments
I personally find Less sure about |
I think I have revised my thoughts here. we should promote (in the doc / the-one-way-to-do-it),
|
They are quite different at the moment:
|
further: |
further: we use |
I have found So I would be happy to deprecate |
I agree this is highly confusing. Is renaming one of those out of the question? Another option might be merging the functionality of |
so the problem as highlited by @jorisvandenbossche is that
We need a combined functionaility of the current signature should be something like this (default for most functions is axis=0)
now as to what to do:
@dkasak interested in taking this on? |
I would suggest simply deprecating/removing
In general, I think we should avoid making small changes in the API for the basic grammar of data manipulation in pandas, unless we rethink things more broadly for a larger, breaking change (e.g., in pandas2). |
sure it is - pandas is going to exist for 1.x for quite some time better to make changes to the right spelling sooner rather than later I am all for deprecating filter and calling it select (or select_labels) |
I don't have time to handle this at the moment, but I may be interested in doing it when time permits if it hasn't been done already by then. FWIW, upon some thought, I still think changing the name of I'm not so sure about dropping the current behaviour of In particular, I have a
and similar to select particular rows. How could this be implemented without current |
can u show a complete example of how using select |
On the pandas-dev mailing list concern was raised about the the deprecation of I think the example makes a point. For me the alternative like |
The deprecation message currently only suggests a replacement for the case I suggest to expand this to:
|
I only just found out about this change and the doc still doesn't give guidance. For actual selection by column value, people also use numpy operators There's still a docbug needed on this, but first we need to know what you actually recommend. |
do we need label selectors? we should for sure just have a single method for this. maybe call it
query_labels
? to be consistent with.query
as the workhorse for data selection..select
(DEPR: deprecate .select() #17633).filter
xref #6599
The text was updated successfully, but these errors were encountered: