Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_html ignores na_rep when float_format set #13828

Closed
paulperry opened this issue Jul 28, 2016 · 1 comment · Fixed by #36690
Closed

to_html ignores na_rep when float_format set #13828

paulperry opened this issue Jul 28, 2016 · 1 comment · Fixed by #36690
Labels
Bug IO HTML read_html, to_html, Styler.apply, Styler.applymap Output-Formatting __repr__ of pandas objects, to_string
Milestone

Comments

@paulperry
Copy link

Code Sample, a copy-pastable example if possible

http://stackoverflow.com/questions/23700835/pandas-to-html-no-value-representation

df = pd.DataFrame([['A',1.2225],['A',]], columns=['Group','Data'])
df.to_html(na_rep="Ted",float_format='{0:.2f}'.format)

Expected Output

Group Data
0 A 1.22
1 A Ted

output of pd.show_versions()

INSTALLED VERSIONS

commit: None
python: 3.5.1.final.0
python-bits: 64
OS: Darwin
OS-release: 15.6.0
machine: x86_64
processor: i386
byteorder: little
LC_ALL: None
LANG: en_US.UTF-8

pandas: 0.18.0
nose: 1.3.7
pip: 8.1.2
setuptools: 20.3
Cython: 0.23.4
numpy: 1.10.4
scipy: 0.17.0
statsmodels: 0.6.1
xarray: None
IPython: 4.1.2
sphinx: 1.3.5
patsy: 0.4.0
dateutil: 2.5.1
pytz: 2016.2
blosc: None
bottleneck: 1.0.0
tables: 3.2.2
numexpr: 2.5
matplotlib: 1.5.1
openpyxl: 2.3.2
xlrd: 0.9.4
xlwt: 1.0.0
xlsxwriter: 0.8.4
lxml: 3.6.0
bs4: 4.4.1
html5lib: None
httplib2: None
apiclient: None
sqlalchemy: 1.0.12
pymysql: None
psycopg2: None
jinja2: 2.8
boto: 2.39.0

@sinhrks
Copy link
Member

sinhrks commented Jul 28, 2016

Thanks. Looks to be caused by around here.

When no formatter is specified, float_format is being used ignoring na_rep.

PR is appreciated!

@sinhrks sinhrks added Bug Output-Formatting __repr__ of pandas objects, to_string labels Jul 28, 2016
@jorisvandenbossche jorisvandenbossche added this to the Next Major Release milestone Jul 29, 2016
@jorisvandenbossche jorisvandenbossche added the IO HTML read_html, to_html, Styler.apply, Styler.applymap label Jul 29, 2016
@jreback jreback modified the milestones: 0.19.0, Next Major Release Sep 20, 2016
@jreback jreback modified the milestones: 0.19.0, 0.19.1 Sep 28, 2016
@jorisvandenbossche jorisvandenbossche modified the milestones: 0.20.0, 0.19.1 Oct 22, 2016
@jreback jreback modified the milestones: 0.20.0, Next Major Release Mar 23, 2017
@jreback jreback modified the milestones: Contributions Welcome, 1.2 Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug IO HTML read_html, to_html, Styler.apply, Styler.applymap Output-Formatting __repr__ of pandas objects, to_string
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants