New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading bz2-compressed tables from URL fails with c-engine in Python 2 #14874

Closed
dhimmel opened this Issue Dec 13, 2016 · 0 comments

Comments

Projects
None yet
3 participants
@dhimmel
Contributor

dhimmel commented Dec 13, 2016

In #14576, we consolidated compression code and introduced support for compressed URLs beyond just gzip. However, as described in #14576 (comment), the c-engine cannot read bz2-compressed URLs in python 2. This error is coming from parser.pyx#L615-L621. There may be potential to entirely bypass this offending code as it appears to duplicate the functionality of _get_handle.

@jreback jreback added this to the Next Major Release milestone Dec 13, 2016

dhimmel added a commit to dhimmel/pandas that referenced this issue Dec 13, 2016

dhimmel added a commit to dhimmel/pandas that referenced this issue Dec 13, 2016

jreback added a commit that referenced this issue Dec 13, 2016

dhimmel added a commit to dhimmel/pandas that referenced this issue Dec 14, 2016

dhimmel added a commit to dhimmel/pandas that referenced this issue Dec 14, 2016

@jorisvandenbossche jorisvandenbossche modified the milestones: 0.20.0, Next Major Release Dec 15, 2016

dhimmel added a commit to dhimmel/pandas that referenced this issue Dec 15, 2016

dhimmel added a commit to dhimmel/pandas that referenced this issue Dec 16, 2016

dhimmel added a commit to dhimmel/pandas that referenced this issue Dec 16, 2016

@jreback jreback closed this in e80a2b9 Dec 17, 2016

ischurov added a commit to ischurov/pandas that referenced this issue Dec 19, 2016

ischurov added a commit to ischurov/pandas that referenced this issue Dec 19, 2016

DOC for refactored compression (GH14576) + BUG: bz2-compressed URL wi…
…th C engine (GH14874)

Follow up on pandas-dev#14576, which
refactored compression code to expand URL support.    Fixes up some
small remaining issues and adds a what's new entry.    - [x] Closes
#14874

Author: Daniel Himmelstein <daniel.himmelstein@gmail.com>

Closes #14880 from dhimmel/whats-new and squashes the following commits:

e1b5d42 [Daniel Himmelstein] Address what's new review comments
8568aed [Daniel Himmelstein] TST: Read bz2 files from S3 in PY2
09dcbff [Daniel Himmelstein] DOC: Improve what's new
c4ea3d3 [Daniel Himmelstein] STY: PEP8 fixes
f8a7900 [Daniel Himmelstein] TST: check bz2 compression in PY2 c engine
0e0fa0a [Daniel Himmelstein] DOC: Reword get_filepath_or_buffer docstring
210fb20 [Daniel Himmelstein] DOC: What's New for refactored compression code
cb91007 [Daniel Himmelstein] TST: Read compressed URLs with c engine
85630ea [Daniel Himmelstein] ENH: Support bz2 compression in PY2 for c engine
a7960f6 [Daniel Himmelstein] DOC: Improve _infer_compression docstring

ShaharBental added a commit to ShaharBental/pandas that referenced this issue Dec 26, 2016

DOC for refactored compression (GH14576) + BUG: bz2-compressed URL wi…
…th C engine (GH14874)

Follow up on pandas-dev#14576, which
refactored compression code to expand URL support.    Fixes up some
small remaining issues and adds a what's new entry.    - [x] Closes
#14874

Author: Daniel Himmelstein <daniel.himmelstein@gmail.com>

Closes #14880 from dhimmel/whats-new and squashes the following commits:

e1b5d42 [Daniel Himmelstein] Address what's new review comments
8568aed [Daniel Himmelstein] TST: Read bz2 files from S3 in PY2
09dcbff [Daniel Himmelstein] DOC: Improve what's new
c4ea3d3 [Daniel Himmelstein] STY: PEP8 fixes
f8a7900 [Daniel Himmelstein] TST: check bz2 compression in PY2 c engine
0e0fa0a [Daniel Himmelstein] DOC: Reword get_filepath_or_buffer docstring
210fb20 [Daniel Himmelstein] DOC: What's New for refactored compression code
cb91007 [Daniel Himmelstein] TST: Read compressed URLs with c engine
85630ea [Daniel Himmelstein] ENH: Support bz2 compression in PY2 for c engine
a7960f6 [Daniel Himmelstein] DOC: Improve _infer_compression docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment