Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIGRATE: pandas-gbq #15347

Closed
jreback opened this issue Feb 8, 2017 · 5 comments
Closed

MIGRATE: pandas-gbq #15347

jreback opened this issue Feb 8, 2017 · 5 comments
Labels
Admin Administrative tasks related to the pandas project
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Feb 8, 2017

I created the pandas-gbq package to migrate the guts of pandas/io/gbq.py. Once this is release and on PyPi and conda-forge. Then we can switch the internal interface to use this code. I think this will allow this package to grow.

@jreback jreback added IO Google Admin Administrative tasks related to the pandas project labels Feb 8, 2017
@jreback jreback added this to the 0.20.0 milestone Feb 8, 2017
@jreback
Copy link
Contributor Author

jreback commented Feb 8, 2017

I have add all pandas to the repo as well as @parthea . If you would like to be added, please ping.

@max-sixty
Copy link
Contributor

CC @clifton

@jorisvandenbossche
Copy link
Member

Big +1 to have this as a separate package.

Then we can switch the internal interface to use this code

@jreback What is your idea on how to approach this?

Let read_gqb/to_gbq call the external package and pass everything on?

Roughly like

def read_gbq(*args, **kwargs):
    from pandas_gbq import read_gbq
    return read_gbq(*args, **kwargs)

class DataFrame():
    ...
    def to_gbq(self, *args, **kwargs):
        from pandas_gbq import to_gbq
        to_gbq(self, *args, **kwargs)

(with of course some checking of the import etc)

@jreback
Copy link
Contributor Author

jreback commented Feb 14, 2017

exactly the internal pandas implementation becomes trivial

@jreback
Copy link
Contributor Author

jreback commented Feb 26, 2017

ok moved all of the docs, so will change that as well: http://pandas-gbq.readthedocs.io/en/latest/index.html#

jreback added a commit to jreback/pandas that referenced this issue Feb 27, 2017
jreback added a commit to jreback/pandas that referenced this issue Feb 27, 2017
jreback added a commit to jreback/pandas that referenced this issue Feb 27, 2017
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this issue Mar 21, 2017
closes pandas-dev#15347

Author: Jeff Reback <jeff@reback.net>

Closes pandas-dev#15484 from jreback/gbq and squashes the following commits:

0fd8d06 [Jeff Reback] wip
3222de1 [Jeff Reback] CLN: remove pandas/io/gbq.py and tests and replace with pandas-gbq
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Administrative tasks related to the pandas project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants