Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: .iloc indexing with duplicates #15686

Closed
toobaz opened this issue Mar 14, 2017 · 3 comments · Fixed by #32477
Closed

BUG: .iloc indexing with duplicates #15686

toobaz opened this issue Mar 14, 2017 · 3 comments · Fixed by #32477
Labels
Bug Dtype Conversions Unexpected or buggy dtype conversions Indexing Related to indexing on series/frames, not to indexes themselves
Milestone

Comments

@toobaz
Copy link
Member

toobaz commented Mar 14, 2017

Code Sample, a copy-pastable example if possible

In [2]: df1 = pd.DataFrame([{'A': None, 'B': 1}, {'A': 2, 'B': 2}])
   ...: df2 = pd.DataFrame([{'A': 3, 'B': 3}, {'A': 4, 'B': 4}])
   ...: df = pd.concat([df1, df2], axis=1)
   ...: df.iloc[0, 0] = df.iloc[0, 2]
   ...: df
   ...: 
Out[2]: 
     A  B    A  B
0  3.0  1  3.0  3
1  2.0  2  4.0  4

Problem description

The third column shouldn't have changed type

Expected Output

Out[2]: 
     A  B  A  B
0  3.0  1  3  3
1  2.0  2  4  4

Output of pd.show_versions()

INSTALLED VERSIONS

commit: 32df1e6
python: 3.5.3.final.0
python-bits: 64
OS: Linux
OS-release: 4.7.0-1-amd64
machine: x86_64
processor:
byteorder: little
LC_ALL: None
LANG: it_IT.utf8
LOCALE: it_IT.UTF-8

pandas: 0.19.0+597.g32df1e6ae
pytest: 3.0.6
pip: 9.0.1
setuptools: 33.1.1
Cython: 0.25.2
numpy: 1.12.0
scipy: 0.18.1
xarray: None
IPython: 5.1.0.dev
sphinx: 1.4.9
patsy: 0.3.0-dev
dateutil: 2.5.3
pytz: 2016.7
blosc: None
bottleneck: 1.2.0
tables: 3.3.0
numexpr: 2.6.1
feather: 0.3.1
matplotlib: 2.0.0
openpyxl: 2.3.0
xlrd: 1.0.0
xlwt: 1.1.2
xlsxwriter: 0.9.6
lxml: 3.7.1
bs4: 4.5.3
html5lib: 0.999999999
sqlalchemy: 1.0.15
pymysql: None
psycopg2: None
jinja2: 2.8
s3fs: None
pandas_gbq: None
pandas_datareader: 0.2.1

@toobaz
Copy link
Member Author

toobaz commented Mar 14, 2017

This looks very similar to #12991 , but it's a different bug: this is a bug in the indexing code (I know because I have a fix), #12991 is a bug in BlockManager.

@toobaz
Copy link
Member Author

toobaz commented Mar 14, 2017

(This is due to setter in pandas/core/indexing.py ultimately relying on obj[.] - and hence on labels - to set values)

@jreback
Copy link
Contributor

jreback commented Mar 14, 2017

yeah this should use an indexer

@jreback jreback added Bug Difficulty Intermediate Dtype Conversions Unexpected or buggy dtype conversions Indexing Related to indexing on series/frames, not to indexes themselves labels Mar 14, 2017
@jreback jreback added this to the Next Major Release milestone Mar 14, 2017
@jreback jreback changed the title iloc changes dtype when it shouldn't (with duplicate names and different dtypes) BUG: .iloc indexing with duplicates Mar 14, 2017
toobaz added a commit to toobaz/pandas that referenced this issue Mar 22, 2017
toobaz added a commit to toobaz/pandas that referenced this issue Mar 22, 2017
@toobaz toobaz mentioned this issue Mar 22, 2017
4 tasks
toobaz added a commit to toobaz/pandas that referenced this issue May 13, 2017
toobaz added a commit to toobaz/pandas that referenced this issue May 13, 2017
toobaz added a commit to toobaz/pandas that referenced this issue Aug 3, 2017
toobaz added a commit to toobaz/pandas that referenced this issue Aug 3, 2017
@toobaz toobaz mentioned this issue Aug 3, 2017
4 tasks
toobaz added a commit to toobaz/pandas that referenced this issue Aug 6, 2017
toobaz added a commit to toobaz/pandas that referenced this issue Aug 6, 2017
toobaz added a commit to toobaz/pandas that referenced this issue Aug 9, 2017
toobaz added a commit to toobaz/pandas that referenced this issue Aug 9, 2017
toobaz added a commit to toobaz/pandas that referenced this issue Aug 9, 2017
toobaz added a commit to toobaz/pandas that referenced this issue Aug 9, 2017
@jbrockmendel jbrockmendel added this to i?loc.__setitem__ in Indexing Feb 18, 2020
@jbrockmendel jbrockmendel moved this from i?loc.__setitem__ to iloc/iat setitem with duplicates in Indexing Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Dtype Conversions Unexpected or buggy dtype conversions Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
3 participants