CLN: replace %s formatting syntax with .format #16130
Labels
Comments
|
Indeed, the f-string syntax would be nice...however, between [6] and [7], I would prefer that we use [7]. True, it is slightly more verbose, but it is also a little clearer. |
|
I'd like to contribute on this one. One question: what about other specifiers, like %d? For some strings, using something like [7] can make some strings that were readable a little less so. For example: |
|
in that case i would use [6] |
|
Keep in mind that some classes define their own formatting rules, e.g. In [45]: dts = pd.Timestamp('2017-01-01T12:03:04')
In [46]: '{:%Y-%m-%d %T}'.format(dts)
Out[46]: '2017-01-01 12:03:04' |
cbertinato
pushed a commit
to cbertinato/pandas
that referenced
this issue
Apr 29, 2017
cbertinato
pushed a commit
to cbertinato/pandas
that referenced
this issue
Aug 3, 2017
This was referenced Aug 10, 2017
This was referenced Aug 18, 2017
4 tasks
|
If we really wanted to, we can add this flake8 plugin when we're done: https://github.com/gforcada/flake8-pep3101 output: |
|
@jschendel I have some changes for this issue. Can we coordinate so I don't make a request for anything you've already done or are working on? |
|
@cbertinato Sure, just let me know what you're working on/want to work on and I'll steer clear. I saw that you made a commit for I don't really have a backlog of stuff I've started working on but haven't submitted a PR for; been working on this in (somewhat) coherent chunks and submit PRs as I finish the chunks. I just started some work on I don't have a set plan for what I'm going to do and when either. I've mostly been trying to read over the pandas codebase to get a better understanding of it, and figured I'd do something productive along the way! |
|
Sounds good. The only I'm working is getting changes to |
1 task
|
I'd like to get your opinions on an issue that arose while working through Here is one example where a format string is passed to a function (1939): which gets passed on to another function (1876): The issue is that if the user specifies anything other than One way to move all of the internal code to Thoughts on how best to proceed? |
|
I think you can get around it with from functools import partial
if self.float_format is None and self.fixed_width:
float_format = partial('{value:.{digits:d}f}'.format, digits=self.digits)and def base_formatter(v):
return float_format(value=v) if notna(v) else self.na_rep |
cbertinato
pushed a commit
to cbertinato/pandas
that referenced
this issue
Aug 26, 2017
Progress toward issue pandas-dev#16130. Converted old string formatting to new string formatting in io/formats/format.py.
cbertinato
pushed a commit
to cbertinato/pandas
that referenced
this issue
Aug 27, 2017
Progress toward issue pandas-dev#16130. Converted old string formatting to new string formatting in core/indexing.py.
cbertinato
pushed a commit
to cbertinato/pandas
that referenced
this issue
Aug 27, 2017
Progress toward issue pandas-dev#16130. Converted old string formatting to new string formatting in core/indexing.py.
cbertinato
pushed a commit
to cbertinato/pandas
that referenced
this issue
Aug 27, 2017
Progress toward issue pandas-dev#16130. Converted old string formatting to new string formatting in core/indexing.py.
1 task
cbertinato
pushed a commit
to cbertinato/pandas
that referenced
this issue
Aug 28, 2017
Progress toward issue pandas-dev#16130. Converted old string formatting to new string formatting in io/formats/format.py.
makeajourney
added a commit
to makeajourney/pandas
that referenced
this issue
Dec 27, 2018
progress towards pandas-dev#16130
makeajourney
added a commit
to makeajourney/pandas
that referenced
this issue
Dec 27, 2018
progress towards pandas-dev#16130
makeajourney
added a commit
to makeajourney/pandas
that referenced
this issue
Dec 27, 2018
progress towards pandas-dev#16130
1 task
makeajourney
added a commit
to makeajourney/pandas
that referenced
this issue
Jan 10, 2019
progress towards pandas-dev#16130
makeajourney
added a commit
to makeajourney/pandas
that referenced
this issue
Jan 11, 2019
progress towards pandas-dev#16130
makeajourney
added a commit
to makeajourney/pandas
that referenced
this issue
Jan 11, 2019
progress towards pandas-dev#16130
2 tasks
makeajourney
added a commit
to makeajourney/pandas
that referenced
this issue
Jan 11, 2019
2 tasks
makeajourney
added a commit
to makeajourney/pandas
that referenced
this issue
Jan 31, 2019
makeajourney
added a commit
to makeajourney/pandas
that referenced
this issue
Feb 2, 2019
makeajourney
added a commit
to makeajourney/pandas
that referenced
this issue
Feb 20, 2019
makeajourney
added a commit
to makeajourney/pandas
that referenced
this issue
Feb 22, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this issue
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this issue
Feb 28, 2019
makeajourney
added a commit
to makeajourney/pandas
that referenced
this issue
Mar 19, 2019
makeajourney
added a commit
to makeajourney/pandas
that referenced
this issue
Mar 19, 2019
makeajourney
added a commit
to makeajourney/pandas
that referenced
this issue
Apr 20, 2019
2 tasks
makeajourney
added a commit
to makeajourney/pandas
that referenced
this issue
Apr 23, 2019
|
I think we can close this issue. I could not see any outstanding cases when performing a grep search. |
jbrockmendel
added
Code Style
This was referenced Nov 6, 2019
|
Closing in favor of #29547 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
only showing a small snippet. There are about 1000 separate incidents of this (including .py and .pyx) files.
This is pretty easy to change of course (though its somewhat manual).
It provides a cleaner syntax (include kwargs optionally, which makes it more readable). and guards
against accidently trying to format a list/tuple.
So replacing [5] with [6] or [7]
Ideally we would even use f-strings, but only >= 3.6 :<
The text was updated successfully, but these errors were encountered: