Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: ujson tests are not being run #16499

Closed
abarber4gh opened this issue May 25, 2017 · 3 comments · Fixed by #16500
Closed

TST: ujson tests are not being run #16499

abarber4gh opened this issue May 25, 2017 · 3 comments · Fixed by #16500
Labels
Testing pandas testing functions or related to the test suite
Milestone

Comments

@abarber4gh
Copy link
Contributor

Code Sample, a copy-pastable example if possible

pytest pandas/tests/io/json/test_ujson.py 
=========================================================== test session starts ============================================================
platform darwin -- Python 3.6.1, pytest-3.0.7, py-1.4.33, pluggy-0.4.0
rootdir: /pandas_dev, inifile: setup.cfg
plugins: cov-2.3.1, xdist-1.16.0
collected 0 items 

======================================================= no tests ran in 0.21 seconds =======================================================

Problem description

likely related to the PyTest move. Classes do not start with keyword Test

Expected Output

likely missing over 100 tests.

@TomAugspurger TomAugspurger added the Testing pandas testing functions or related to the test suite label May 25, 2017
@TomAugspurger TomAugspurger added this to the 0.20.2 milestone May 25, 2017
@TomAugspurger
Copy link
Contributor

Thanks... Do you have a chance to submit a fix?

@abarber4gh
Copy link
Contributor Author

I'll update with a fix.

@TomAugspurger
Copy link
Contributor

TomAugspurger commented May 25, 2017

This is from this regex class [^T|t].*TestCase\): on 0.19.2

pandas/io/tests/json/test_ujson.py:38:class UltraJSONTests(TestCase):
pandas/io/tests/json/test_ujson.py:919:class NumpyJSONTests(TestCase):
pandas/io/tests/json/test_ujson.py:1195:class PandasJSONTests(TestCase):
pandas/io/tests/test_gbq.py:358:class GBQUnitTests(tm.TestCase):
pandas/io/tests/test_excel.py:938:class XlsReaderTests(XlrdTests, tm.TestCase):
pandas/io/tests/test_excel.py:944:class XlsxReaderTests(XlrdTests, tm.TestCase):
pandas/io/tests/test_excel.py:950:class XlsmReaderTests(XlrdTests, tm.TestCase):
pandas/io/tests/test_excel.py:1824:class OpenpyxlTests(ExcelWriterBase, tm.TestCase):
pandas/io/tests/test_excel.py:1877:class Openpyxl20Tests(ExcelWriterBase, tm.TestCase):
pandas/io/tests/test_excel.py:1993:class Openpyxl22Tests(ExcelWriterBase, tm.TestCase):
pandas/io/tests/test_excel.py:2088:class XlwtTests(ExcelWriterBase, tm.TestCase):
pandas/io/tests/test_excel.py:2145:class XlsxWriterTests(ExcelWriterBase, tm.TestCase):
pandas/io/tests/test_excel.py:2191:class OpenpyxlTests_NoMerge(ExcelWriterBase, tm.TestCase):
pandas/io/tests/test_excel.py:2200:class XlwtTests_NoMerge(ExcelWriterBase, tm.TestCase):
pandas/io/tests/test_excel.py:2209:class XlsxWriterTests_NoMerge(ExcelWriterBase, tm.TestCase):
pandas/io/tests/test_excel.py:2218:class ExcelWriterEngineTests(tm.TestCase):
pandas/io/tests/test_sql.py:239:class PandasSQLTest(unittest.TestCase):
pandas/io/tests/test_pytables.py:147:class Base(tm.TestCase):
pandas/stats/tests/common.py:57:class BaseTest(tm.TestCase):
pandas/tests/test_base.py:215:class Ops(tm.TestCase):
pandas/tests/test_window.py:33:class Base(tm.TestCase):
pandas/tools/tests/test_concat.py:20:class ConcatenateBase(tm.TestCase):
pandas/tseries/tests/test_offsets.py:100:class Base(tm.TestCase):

The excel ones have already been taken care of. The GBQ tests have been moved. I believe all the rest are base classes, so there shouldn't be any others.

Thanks for catching these @abarber4gh

TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this issue May 29, 2017
TomAugspurger pushed a commit that referenced this issue May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants