ENH: Allow referencing of Excel columns by their Excel column names. #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All you have to do is push additional commits to the branch (well, your master branch in this case-- see http://pandas.pydata.org/developers.html#working-with-the-code for the future). Would you mind adding a unit test that addresses this new behavior (you can use one of the .xls files that are already used in the test suite) |
added 2 commits
September 20, 2012 10:04
|
Thanks Wes. I wanted that feature for myself so I just started hacking at it. I will follow the guidelines in future. I've made the change I pointed out above and added a unit test for the 'str' behaviour that replicates the existing parse_cols unit tests. Please review and see if you're happy with it. |
added 5 commits
September 20, 2012 11:38
Conflicts: pandas/io/tests/test_parsers.py
|
cherry-picked the relevant commits. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find it more convenient to refer to the columns as they are in Excel by their string representations.
The excel2num() function I found on StackOverflow. Does that need to be referenced/acknowledged?
I'm happy to put in some unit tests but couldn't find a natural home for it. Most of the ExcelFile tests sit in test_frame.py but I think something like test_io.py or test_parsers.py would be a better fit.