Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Such thing as a scalar Categorical? #19523

Closed
jbrockmendel opened this issue Feb 3, 2018 · 4 comments
Closed

Such thing as a scalar Categorical? #19523

jbrockmendel opened this issue Feb 3, 2018 · 4 comments

Comments

@jbrockmendel
Copy link
Member

core.ops has a check elif is_categorical_dtype(y) and not is_scalar(y):.

AFAICT the only case with is_categorical_dtype that is scalar is "category". Am I missing a non-trivial case?

@jreback
Copy link
Contributor

jreback commented Feb 4, 2018

this is prob not used any longer, the is_categorical_dtype is enough.

@jreback jreback closed this as completed Feb 4, 2018
@jbrockmendel
Copy link
Member Author

In the tests this gets hit by df.dtypes == 'category'

@jreback
Copy link
Contributor

jreback commented Feb 4, 2018

can u make a comment to that effect in the code and tests

@jbrockmendel
Copy link
Member Author

Yah, planning to handle the categorical_dtype case in core.ops after pinning down the canonical behavior in #19513 and debugging #19524.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants