DEPR: deprecated sheetname from ExcelFile.parse
#20938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ExcelFile.parse * Made to raise FutureWarning and TypeError when using `sheetname` * ExcelFile._parse_excel * Changed parameter name from `sheetname` to `sheet_name`
Codecov Report
@@ Coverage Diff @@
## master #20938 +/- ##
==========================================
- Coverage 91.81% 91.81% -0.01%
==========================================
Files 153 153
Lines 49471 49479 +8
==========================================
+ Hits 45422 45428 +6
- Misses 4049 4051 +2
Continue to review full report at Codecov.
|
jreback
requested changes
May 3, 2018
| @@ -435,7 +435,16 @@ def parse(self, | |||
| docstring for more info on accepted parameters | |||
| """ | |||
|
|
|||
| return self._parse_excel(sheetname=sheet_name, | |||
There was a problem hiding this comment.
is fine that you added this here, but you need to remove it from the other section. (which just creates an ExcelFile and then calls _parse_excel, just redirect it to call .parse
jreback
added
IO Excel
1 task
* removed error/warning raising process from read_excel * changed calling method from ExcelFile._parse_excel to ExcelFile.parse, which calls _parse_excel and raises the same error/warning Related issue: pandas-dev#20920
jreback
approved these changes
May 4, 2018
|
thanks @deflatSOCO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sheetnamesheetnametosheet_namegit diff upstream/master -u -- "*.py" | flake8 --diff