Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: deprecated `sheetname` from ExcelFile.parse #20938

Merged
merged 2 commits into from May 4, 2018

Conversation

@deflatSOCO
Copy link
Contributor

commented May 3, 2018

  • ExcelFile.parse
    • Made to raise FutureWarning and TypeError when using sheetname
  • ExcelFile._parse_excel
    • Changed parameter name from sheetname to sheet_name
  • closes #20920
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry
DEPR: deprecated `sheetname` from ExcelFile.parse
* ExcelFile.parse
  * Made to raise FutureWarning and TypeError when using `sheetname`
* ExcelFile._parse_excel
  * Changed parameter name from `sheetname` to `sheet_name`
@codecov

This comment has been minimized.

Copy link

commented May 3, 2018

Codecov Report

Merging #20938 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20938      +/-   ##
==========================================
- Coverage   91.81%   91.81%   -0.01%     
==========================================
  Files         153      153              
  Lines       49471    49479       +8     
==========================================
+ Hits        45422    45428       +6     
- Misses       4049     4051       +2
Flag Coverage Δ
#multiple 90.2% <ø> (-0.01%) ⬇️
#single 41.85% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 84.38% <0%> (-0.21%) ⬇️
pandas/core/reshape/merge.py 94.25% <0%> (ø) ⬆️
pandas/core/algorithms.py 94.5% <0%> (+0.01%) ⬆️
pandas/core/indexes/datetimes.py 95.76% <0%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce4ab82...1b893df. Read the comment docs.

@@ -435,7 +435,16 @@ def parse(self,
docstring for more info on accepted parameters
"""

return self._parse_excel(sheetname=sheet_name,

This comment has been minimized.

Copy link
@jreback

jreback May 3, 2018

Contributor

is fine that you added this here, but you need to remove it from the other section. (which just creates an ExcelFile and then calls _parse_excel, just redirect it to call .parse

@jsexauer jsexauer referenced this pull request May 3, 2018

Open

DEPR: deprecations from prior versions #6581

0 of 89 tasks complete
CLN: removed error/warning raising process from read_excel
* removed error/warning raising process from read_excel
* changed calling method from ExcelFile._parse_excel to ExcelFile.parse,
which calls _parse_excel and raises the same error/warning

Related issue: #20920

@jreback jreback added this to the 0.23.0 milestone May 4, 2018

@jreback

jreback approved these changes May 4, 2018

@jreback jreback merged commit ec4609e into pandas-dev:master May 4, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jreback

This comment has been minimized.

Copy link
Contributor

commented May 4, 2018

thanks @deflatSOCO

@jreback jreback referenced this pull request May 24, 2019

Open

DEPR: deprecations log for removed issues #13777

141 of 141 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.