DEPR: Add deprecated index attribute names to deprecation list

[topper-123]

In ipython, when you press tab (e.g. idx.<tab>) a long list of deprecations shows up:

C:\Users\TP\Miniconda3\envs\pandas-dev\lib\site-packages\jedi\evaluate\compiled\__init__.py:328: FutureWarning: Int64Index.base is deprecated and will be removed in a future version
  getattr(obj, name)
C:\Users\TP\Miniconda3\envs\pandas-dev\lib\site-packages\jedi\evaluate\compiled\__init__.py:328: FutureWarning: Int64Index.data is deprecated and will be removed in a future version
  getattr(obj, name)
C:\Users\TP\Miniconda3\envs\pandas-dev\lib\site-packages\jedi\evaluate\compiled\__init__.py:328: FutureWarning: Int64Index.flags is deprecated and will be removed in a future version
  getattr(obj, name)
C:\Users\TP\Miniconda3\envs\pandas-dev\lib\site-packages\jedi\evaluate\compiled\__init__.py:328: FutureWarning: Int64Index.itemsize is deprecated and will be removed in a future version
  getattr(obj, name)
C:\Users\TP\Miniconda3\envs\pandas-dev\lib\site-packages\jedi\evaluate\compiled\__init__.py:328: FutureWarning: Int64Index.strides is deprecated and will be removed in a future version
  getattr(obj, name)

With this PR we avoid getting that list of deprecations in iPython.

I'm not sure if/where this should go in the whatsnew document.

[jreback]

i think we have a test for exactly this but for Series (and for the main object not accessors)

can u add one here

[topper-123]

Not able to locate t. Where its name?

[codecov]

Codecov Report

Merging #21125 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #21125   +/-   ##
=======================================
  Coverage   91.84%   91.84%           
=======================================
  Files         153      153           
  Lines       49499    49499           
=======================================
  Hits        45460    45460           
  Misses       4039     4039

Flag	Coverage Δ
#multiple	90.23% <100%> (ø)	⬆️
#single	41.88% <100%> (ø)	⬆️

Impacted Files	Coverage Δ
pandas/core/accessor.py	98.71% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc37ea2...a54b416. Read the comment docs.

[jschendel]

I think this is the test @jreback is referring to:

pandas/pandas/tests/series/test_api.py

Lines 465 to 474 in e033c06

	def test_tab_complete_warning(self, ip):
	# https://github.com/pandas-dev/pandas/issues/16409
	pytest.importorskip('IPython', minversion="6.0.0")
	from IPython.core.completer import provisionalcompleter
	code = "import pandas as pd; s = pd.Series()"
	ip.run_code(code)
	with tm.assert_produces_warning(None):
	with provisionalcompleter('ignore'):
	list(ip.Completer.completions('s.', 1))

There are also instances of this test (same name) in frame\test_api.py and categorical\test_warnings.py

[topper-123]

test added. Is the location ok?

[topper-123]

BTW, @jschendel in line 474 in the test_api.py file you showed

pandas/pandas/tests/series/test_api.py

Lines 472 to 474 in e033c06

	with tm.assert_produces_warning(None):
	with provisionalcompleter('ignore'):
	list(ip.Completer.completions('s.', 1))

I think list(ip.Completer.completions('s.', 1)) should be list(ip.Completer.completions('s.', 2)) in order to produce the warnings, do you not agree? With 1 the tab is pressed after 's' which is too early.

[jreback]

looks ok. can you add a whatsnew note (0.23.1)

[topper-123]

green.

[jreback]

thanks!

[jorisvandenbossche]

BTW, this only adds them to Index, not to Series.
So not sure why you did get warnings for Index, but not for Series in the first place.