-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataFrame.asof() : Timezone Awareness / Naivety comparison TypeError (incorrect) #21194
Comments
Thanks for the report. It is indeed reproducible. The bug is in pandas/pandas/core/indexes/base.py Line 2489 in 6f1f975
For a tz-aware DatetimeIndex The simplest fix is to maybe make that comparison be |
@TomAugspurger I have checked your solution and it actually solve the problem. If you need some help I can make the correction and implement the test. |
That would be great. Let us know if you have any issues getting started.
…On Tue, May 29, 2018 at 7:41 AM, Marlene Silva Marchena < ***@***.***> wrote:
@TomAugspurger <https://github.com/TomAugspurger> I have checked your
solution and it actually solve the problem. If you need some help I can
make the correction and implement the test.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21194 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIgxZGpxUKyMP2LT5NlThM67HAoqdks5t3V4OgaJpZM4UMpnE>
.
|
Any progress on this? 0.23 still doesn't work for me. |
Looks like #21284 is stalled. Feel
free to pick it up if you're interested.
…On Fri, Aug 3, 2018 at 3:42 PM Daniel Wang ***@***.***> wrote:
Any progress on this? 0.23 still doesn't work for me.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21194 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIjN9y2iRijkGuRainCNll5ChXiuhks5uNLW9gaJpZM4UMpnE>
.
|
Sorry, I have been travelling and without time to work on this. Since I have done a mess with PR21284 |
Problem description
Somehow the DataFrame index is losing the 'awareness' of the timezone of the original Timestamps.
This has only been noticed recently, following a recent upgrade to the newest version of pandas, however I cannot say for sure whether or not it has been a very recent change to pandas which has caused this.
I am confident (though not 100% certain) that the expected usage worked previously (nor am in a position to test right now).
EDIT: Have tested this with pandas=0.22.0 and the expected output is now working fine.
Hopefully the bug is reproducible.
Expected Output
0 1
Name: 2018-01-01 23:22:43.324500+0000, dtype: int64
Output of
pd.show_versions()
[paste the output of
pd.show_versions()
here below this line]pd.show_versions()
Matplotlib support failed
INSTALLED VERSIONS
commit: None
python: 3.6.5.final.0
python-bits: 64
OS: Windows
OS-release: 10
machine: AMD64
processor: Intel64 Family 6 Model 62 Stepping 4, GenuineIntel
byteorder: little
LC_ALL: None
LANG: None
LOCALE: None.None
pandas: 0.23.0
pytest: None
pip: 10.0.1
setuptools: 39.1.0
Cython: 0.28.2
numpy: 1.13.3
scipy: 1.1.0
pyarrow: 0.7.0
xarray: 0.10.4
IPython: 6.4.0
sphinx: 1.7.4
patsy: 0.5.0
dateutil: 2.7.3
pytz: 2018.4
blosc: None
bottleneck: None
tables: 3.4.3
numexpr: 2.6.5
feather: 0.4.0
matplotlib: 2.2.2
openpyxl: 2.5.3
xlrd: 1.1.0
xlwt: None
xlsxwriter: 1.0.4
lxml: 4.2.1
bs4: 4.6.0
html5lib: 0.9999999
sqlalchemy: 1.2.7
pymysql: None
psycopg2: None
jinja2: 2.10
s3fs: None
fastparquet: None
pandas_gbq: None
pandas_datareader: None
The text was updated successfully, but these errors were encountered: