Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove PeriodIndex.tz_convert, tz_localize? #21781

Closed
jbrockmendel opened this issue Jul 7, 2018 · 0 comments · Fixed by #21935
Closed

remove PeriodIndex.tz_convert, tz_localize? #21781

jbrockmendel opened this issue Jul 7, 2018 · 0 comments · Fixed by #21935
Labels
Error Reporting Incorrect or improved errors from pandas Timezones Timezone data dtype
Milestone
0.24.0

Comments

@jbrockmendel
Copy link
Member

ATM they just raise NotImplementedError("Not yet implemented for PeriodIndex"); if the idea of Period ever gaining a tz is out, these should be too.
@jreback jreback added Error Reporting Incorrect or improved errors from pandas Timezones Timezone data dtype labels Jul 7, 2018
@jreback jreback added this to the Contributions Welcome milestone Jul 7, 2018
@jquinon jquinon mentioned this issue Jul 16, 2018
Merged
2 tasks
@jreback jreback modified the milestones: Contributions Welcome, 0.24.0 Jul 16, 2018
gfyoung pushed a commit that referenced this issue Jul 18, 2018
@jquinon @gfyoung
CLN: Remove PeriodIndex.tz_convert, tz_localize (#21935)
4b73f22 
CLN: Removed tz_convert and tz_localize from PeriodIndex

Closes gh-21781
aeltanawy pushed a commit to aeltanawy/pandas that referenced this issue Jul 20, 2018
@jquinon @aeltanawy
CLN: Remove PeriodIndex.tz_convert, tz_localize (pandas-dev#21935)
a254468 
CLN: Removed tz_convert and tz_localize from PeriodIndex

Closes pandas-devgh-21781
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this issue Oct 1, 2018
@jquinon
CLN: Remove PeriodIndex.tz_convert, tz_localize (pandas-dev#21935)
bbd5eae 
CLN: Removed tz_convert and tz_localize from PeriodIndex

Closes pandas-devgh-21781
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Error Reporting Incorrect or improved errors from pandas Timezones Timezone data dtype
Projects
None yet
Milestone
0.24.0
Development

Successfully merging a pull request may close this issue.

CLN: Remove PeriodIndex.tz_convert, tz_localize
2 participants
@jreback @jbrockmendel