Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: Pandas 0.24.0 Deprecations #21894

Closed
3 tasks
TomAugspurger opened this issue Jul 13, 2018 · 10 comments
Closed
3 tasks

DEPR: Pandas 0.24.0 Deprecations #21894

TomAugspurger opened this issue Jul 13, 2018 · 10 comments
Labels
Blocker Blocking issue or pull request for an upcoming release Deprecate Functionality to remove in pandas Master Tracker High level tracker for similar issues
Milestone

Comments

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Jul 13, 2018

We'd like to have all these deprecations in place for 0.24.0, and enforced in 1.0

As a reminder, the plan is to have no new deprecations in 0.25.x and 1.0.0. So this is the last round of deprecations before 1.0.

cc @pandas-dev/pandas-core

@TomAugspurger TomAugspurger added Blocker Blocking issue or pull request for an upcoming release Master Tracker High level tracker for similar issues labels Jul 13, 2018
@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Jul 13, 2018
@TomAugspurger
Copy link
Contributor Author

@jorisvandenbossche @jreback do you know the current thoughts on deprecating filter? Just need someone to do it? I'm going to do Series.rename(scalar) now, will follow up with filter if so.

If people have thoughts on .between, discuss in #13027 and I'll update here.

Feel free to add additional deprecations that we don't want to live with for 1.x.

@shoyer
Copy link
Member

shoyer commented Jul 13, 2018

@TomAugspurger I hate to revisit things... but do you mind holding off for a little while on Series.rename? I'd like to take a look at #14829, maybe revisit some alternative APIs...

@TomAugspurger
Copy link
Contributor Author

No worries. I think the decision on Series.rename(scalar) does depend on the decision in #14829.

@jorisvandenbossche
Copy link
Member

As I said during the sprint, I am personally not in favor of deprecating the full filter method, but would rather like to deprecate the default axis, so we can keep it for the obvious behaviour (but need to look into it in more detail to explore if this is somewhat possible).

@TomAugspurger
Copy link
Contributor Author

but would rather like to deprecate the default axis

When you get a chance, can you write that up? I'm having trouble recalling the discussion.

@gfyoung gfyoung added the Deprecate Functionality to remove in pandas label Jul 13, 2018
@topper-123
Copy link
Contributor

I think NDFrame.filter provides some nice functionality, but has an unfortunate name that can be mixed up with Groupby.filter.

I'd like to keep it, but rename it to something else perhaps.

@jreback
Copy link
Contributor

jreback commented Jul 13, 2018

I think between is ok (no deprecation)

what happened to the original list which was much longer?

@topper-123
Copy link
Contributor

Older longer list: #18262

@h-vetinari
Copy link
Contributor

h-vetinari commented Jul 16, 2018

Most likely too late to the game, but for completeness I'd like to add: if #21855 #21858 are solved for v0.24, then combine_first could be deprecated at the same time, see #21859.

@TomAugspurger
Copy link
Contributor Author

Sorry, I forgot about #18262

Let's move this discussion there.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker Blocking issue or pull request for an upcoming release Deprecate Functionality to remove in pandas Master Tracker High level tracker for similar issues
Projects
None yet
Development

No branches or pull requests

7 participants