Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: unify signature for df.update and Series.update #22358

Open
h-vetinari opened this issue Aug 15, 2018 · 0 comments
Open

ENH: unify signature for df.update and Series.update #22358

h-vetinari opened this issue Aug 15, 2018 · 0 comments
Labels
API - Consistency Internal Consistency of API/Behavior Enhancement

Comments

@h-vetinari
Copy link
Contributor

Currently, there's

DataFrame.update(other, join='left', overwrite=True, filter_func=None, raise_conflict=False)
and
Series.update(other)

I think Series should have the same keywords/capabilities, and ideally share the implementation, probably in generic.py. Relevant also in light of #22286 and #21855.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API - Consistency Internal Consistency of API/Behavior Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

API: Unify .update to generic h-vetinari/pandas
3 participants
@jbrockmendel @mroeschke @h-vetinari