Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat: re-write legacy files for io tests #25250

Closed
jbrockmendel opened this issue Feb 9, 2019 · 6 comments
Closed

Compat: re-write legacy files for io tests #25250

jbrockmendel opened this issue Feb 9, 2019 · 6 comments
Labels
Compat pandas objects compatability with Numpy or Python functions IO Data IO issues that don't fit into a more specific label Testing pandas testing functions or related to the test suite

Comments

@jbrockmendel
Copy link
Member

#25238 introduced a kludge in test_pickle and test_msgpack to ignore the Panel objects when unpickling/unpacking files produced using older versions. The right way to do this is to re-write those files without Panels in them to begin with.

@gfyoung gfyoung added Testing pandas testing functions or related to the test suite IO Data IO issues that don't fit into a more specific label Compat pandas objects compatability with Numpy or Python functions labels Feb 9, 2019
@gfyoung
Copy link
Member

gfyoung commented Feb 9, 2019

Unless we plan to explicitly drop support for older files, I don't think all of them should be rewritten. Most of them sure, but we should leave a couple of tests to ensure backwards compatibility of some sort.

@jreback
Copy link
Contributor

jreback commented Feb 9, 2019

the idea is to rewrite them with the older version of pandas but with the generate from master

this ensures that Panels are not written but ensures backward compat

@jbrockmendel
Copy link
Member Author

AFAICT this is a blocker for removing Panel. I was unable to find a way to patch the pickle tests to not raise if Panel does not exist.

@WillAyd
Copy link
Member

WillAyd commented Jun 5, 2019

Just so I'm clear on expectation we don't need to go back and change all of the historical pickle files do we? We have some of these going back to 0.10.1 - I'm assuming older ones we can just let be historical artifacts? Do we just now need one file per OS?

@jbrockmendel
Copy link
Member Author

I think the idea is to re-write the historical ones using old pandas but up-to-date generate_files_whatever.py

(For orthogonal reasons I'd be +1 on trimming how many old versions we support for pickle compat)

@WillAyd
Copy link
Member

WillAyd commented Jun 27, 2019

closed by #27082

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compat pandas objects compatability with Numpy or Python functions IO Data IO issues that don't fit into a more specific label Testing pandas testing functions or related to the test suite
Projects
None yet
Development

No branches or pull requests

4 participants