[ENH] Move intersection functions for DatetimeIndex and TimedeltaIndex to Datetimelike and added new tests

[fdroessler]

• closes TimedeltaIndex.intersection has no sort option. #24966
• tests added / passed
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

Because DatetimeIndex and TimedeltaIndex intersections are similar, I have moved the intersection function of both classes up into Datetimelike after discussions with @reidy-p @jorisvandenbossche. At the same time for PeriodIndex I have used Index.intersection instead. Additionally I have added some tests to TimedeltaIndex recycling some tests from DatetimeIndex.

Re-open from #25121

[codecov]

Codecov Report

Merging #25913 into master will increase coverage by <.01%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master   #25913      +/-   ##
==========================================
+ Coverage   91.56%   91.56%   +<.01%     
==========================================
  Files         175      175              
  Lines       52775    52760      -15     
==========================================
- Hits        48324    48312      -12     
+ Misses       4451     4448       -3

Flag	Coverage Δ
#multiple	90.13% <93.75%> (ø)	⬆️
#single	41.84% <43.75%> (-0.06%)	⬇️

Impacted Files	Coverage Δ
pandas/core/indexes/period.py	92.12% <100%> (+0.05%)	⬆️
pandas/core/indexes/datetimes.py	96.86% <100%> (+0.45%)	⬆️
pandas/core/indexes/timedeltas.py	91.09% <100%> (+0.82%)	⬆️
pandas/core/indexes/datetimelike.py	97.89% <92.3%> (-0.64%)	⬇️
pandas/io/gbq.py	75% <0%> (-12.5%)	⬇️
pandas/core/frame.py	96.79% <0%> (-0.12%)	⬇️
pandas/util/testing.py	90.56% <0%> (+0.1%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31b4019...05c2916. Read the comment docs.

[codecov]

Codecov Report

Merging #25913 into master will increase coverage by <.01%.
The diff coverage is 95.45%.

@@            Coverage Diff             @@
##           master   #25913      +/-   ##
==========================================
+ Coverage   91.97%   91.97%   +<.01%     
==========================================
  Files         175      175              
  Lines       52368    52349      -19     
==========================================
- Hits        48164    48148      -16     
+ Misses       4204     4201       -3

Flag	Coverage Δ
#multiple	90.53% <95.45%> (ø)	⬆️
#single	40.72% <52.27%> (-0.12%)	⬇️

Impacted Files	Coverage Δ
pandas/core/indexes/period.py	92.1% <100%> (+0.05%)	⬆️
pandas/core/indexes/datetimes.py	96.85% <100%> (+0.45%)	⬆️
pandas/core/indexes/timedeltas.py	91.59% <100%> (+0.86%)	⬆️
pandas/core/indexes/datetimelike.py	98.13% <94.28%> (-0.4%)	⬇️
pandas/io/gbq.py	78.94% <0%> (-10.53%)	⬇️
pandas/core/frame.py	96.9% <0%> (-0.12%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9feb3ad...0d7205d. Read the comment docs.

[fdroessler]

@gfyoung not sure if I should mark the comments as resolved or if you do it once you had a look at it. Please let me know what the general practice is on those so I know for the future.

[fdroessler]

@jreback Is there anything else? Do you want me to create a new issue re restructuring the tests?

[jreback]

small comments, yes pls file an issue to consolidate set_op tests across indexes

[jreback]

@TomAugspurger if you could have a look

[TomAugspurger]

Probably won’t be able to for a while. Don’t hold this up because of me.

…

On Apr 12, 2019, at 06:39, Jeff Reback ***@***.***> wrote: @TomAugspurger if you could have a look — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[jreback]

@fdroessler can you merge master and will have a look.

[fdroessler]

@jreback sure, done

[jreback]

can you merge master

[fdroessler]

Done @jreback

[jreback]

thanks @fdroessler very nice!