Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN/PERF: remove gc.collect from the setting_with_copy checks as not needed #27031

Merged
merged 3 commits into from
Jun 27, 2019

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Jun 25, 2019

This doesn't look might much of a perf gain, but in practice the gc collect can happen at odd times, so this change removes this uncertainty (and is much simpler code)

(pandas) bash-3.2$ asv continuous --bench chained_indexing master gc --config asv_bench/asv.conf.json 
· Creating environments
· Discovering benchmarks
· Running 2 total benchmarks (2 commits * 1 environments * 1 benchmarks)
[  0.00%] · For pandas commit d94146cf <master> (round 1/2):
[  0.00%] ·· Building for conda-py3.6-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-pytest-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt...........
[  0.00%] ·· Benchmarking conda-py3.6-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-pytest-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt
[ 25.00%] ··· Running (indexing.ChainIndexing.time_chained_indexing--).
[ 25.00%] · For pandas commit ab6cb31d <gc> (round 1/2):
[ 25.00%] ·· Building for conda-py3.6-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-pytest-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt...
[ 25.00%] ·· Benchmarking conda-py3.6-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-pytest-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt
[ 50.00%] ··· Running (indexing.ChainIndexing.time_chained_indexing--).
[ 50.00%] · For pandas commit ab6cb31d <gc> (round 2/2):
[ 50.00%] ·· Benchmarking conda-py3.6-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-pytest-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt
[ 75.00%] ··· indexing.ChainIndexing.time_chained_indexing                                                                                                                                                                                      ok
[ 75.00%] ··· ====== ==========
               mode            
              ------ ----------
               None   72.6±5ms 
               warn   67.2±4ms 
              ====== ==========

[ 75.00%] · For pandas commit d94146cf <master> (round 2/2):
[ 75.00%] ·· Building for conda-py3.6-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-pytest-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt...
[ 75.00%] ·· Benchmarking conda-py3.6-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-pytest-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt
[100.00%] ··· indexing.ChainIndexing.time_chained_indexing                                                                                                                                                                                      ok
[100.00%] ··· ====== ==========
               mode            
              ------ ----------
               None   69.4±4ms 
               warn   79.5±4ms 
              ====== ==========


BENCHMARKS NOT SIGNIFICANTLY CHANGED.

@jreback jreback added Performance Memory or execution speed performance Clean labels Jun 25, 2019
@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #27031 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27031      +/-   ##
==========================================
- Coverage   91.99%   91.99%   -0.01%     
==========================================
  Files         180      180              
  Lines       50774    50767       -7     
==========================================
- Hits        46711    46701      -10     
- Misses       4063     4066       +3
Flag Coverage Δ
#multiple 90.63% <100%> (-0.01%) ⬇️
#single 41.86% <10.52%> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 94.18% <100%> (-0.02%) ⬇️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.94% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ea2d08...4c84aa9. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #27031 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27031      +/-   ##
==========================================
- Coverage   92.04%   92.03%   -0.02%     
==========================================
  Files         180      180              
  Lines       50714    50707       -7     
==========================================
- Hits        46680    46668      -12     
- Misses       4034     4039       +5
Flag Coverage Δ
#multiple 90.67% <100%> (-0.01%) ⬇️
#single 41.87% <10.52%> (-0.1%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 94.18% <100%> (-0.02%) ⬇️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.84% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d94146c...ab6cb31. Read the comment docs.

@jreback
Copy link
Contributor Author

jreback commented Jun 27, 2019

@pandas-dev/pandas-core ok with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants