Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN/PERF: remove gc.collect from the setting_with_copy checks as not needed #27031

Merged
merged 3 commits into from Jun 27, 2019

Conversation

@jreback
Copy link
Contributor

commented Jun 25, 2019

This doesn't look might much of a perf gain, but in practice the gc collect can happen at odd times, so this change removes this uncertainty (and is much simpler code)

(pandas) bash-3.2$ asv continuous --bench chained_indexing master gc --config asv_bench/asv.conf.json 
· Creating environments
· Discovering benchmarks
· Running 2 total benchmarks (2 commits * 1 environments * 1 benchmarks)
[  0.00%] · For pandas commit d94146cf <master> (round 1/2):
[  0.00%] ·· Building for conda-py3.6-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-pytest-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt...........
[  0.00%] ·· Benchmarking conda-py3.6-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-pytest-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt
[ 25.00%] ··· Running (indexing.ChainIndexing.time_chained_indexing--).
[ 25.00%] · For pandas commit ab6cb31d <gc> (round 1/2):
[ 25.00%] ·· Building for conda-py3.6-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-pytest-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt...
[ 25.00%] ·· Benchmarking conda-py3.6-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-pytest-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt
[ 50.00%] ··· Running (indexing.ChainIndexing.time_chained_indexing--).
[ 50.00%] · For pandas commit ab6cb31d <gc> (round 2/2):
[ 50.00%] ·· Benchmarking conda-py3.6-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-pytest-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt
[ 75.00%] ··· indexing.ChainIndexing.time_chained_indexing                                                                                                                                                                                      ok
[ 75.00%] ··· ====== ==========
               mode            
              ------ ----------
               None   72.6±5ms 
               warn   67.2±4ms 
              ====== ==========

[ 75.00%] · For pandas commit d94146cf <master> (round 2/2):
[ 75.00%] ·· Building for conda-py3.6-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-pytest-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt...
[ 75.00%] ·· Benchmarking conda-py3.6-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-pytest-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt
[100.00%] ··· indexing.ChainIndexing.time_chained_indexing                                                                                                                                                                                      ok
[100.00%] ··· ====== ==========
               mode            
              ------ ----------
               None   69.4±4ms 
               warn   79.5±4ms 
              ====== ==========


BENCHMARKS NOT SIGNIFICANTLY CHANGED.
@codecov

This comment has been minimized.

Copy link

commented Jun 25, 2019

Codecov Report

Merging #27031 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27031      +/-   ##
==========================================
- Coverage   91.99%   91.99%   -0.01%     
==========================================
  Files         180      180              
  Lines       50774    50767       -7     
==========================================
- Hits        46711    46701      -10     
- Misses       4063     4066       +3
Flag Coverage Δ
#multiple 90.63% <100%> (-0.01%) ⬇️
#single 41.86% <10.52%> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 94.18% <100%> (-0.02%) ⬇️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.94% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ea2d08...4c84aa9. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Jun 25, 2019

Codecov Report

Merging #27031 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27031      +/-   ##
==========================================
- Coverage   92.04%   92.03%   -0.02%     
==========================================
  Files         180      180              
  Lines       50714    50707       -7     
==========================================
- Hits        46680    46668      -12     
- Misses       4034     4039       +5
Flag Coverage Δ
#multiple 90.67% <100%> (-0.01%) ⬇️
#single 41.87% <10.52%> (-0.1%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 94.18% <100%> (-0.02%) ⬇️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.84% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d94146c...ab6cb31. Read the comment docs.

@jreback jreback added this to the 0.25.0 milestone Jun 25, 2019

@jreback jreback force-pushed the jreback:gc branch from 4c84aa9 to a858805 Jun 25, 2019

@jreback jreback force-pushed the jreback:gc branch from a858805 to ab6cb31 Jun 27, 2019

@jreback

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2019

@pandas-dev/pandas-core ok with this?

@jbrockmendel jbrockmendel merged commit c1673cf into pandas-dev:master Jun 27, 2019

12 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
pandas-dev.pandas Build #20190627.1 succeeded
Details
pandas-dev.pandas (Checks) Checks succeeded
Details
pandas-dev.pandas (Docs) Docs succeeded
Details
pandas-dev.pandas (Linux py35_compat) Linux py35_compat succeeded
Details
pandas-dev.pandas (Linux py36_locale_slow) Linux py36_locale_slow succeeded
Details
pandas-dev.pandas (Linux py36_locale_slow_old_np) Linux py36_locale_slow_old_np succeeded
Details
pandas-dev.pandas (Linux py37_locale) Linux py37_locale succeeded
Details
pandas-dev.pandas (Linux py37_np_dev) Linux py37_np_dev succeeded
Details
pandas-dev.pandas (Windows py36_np15) Windows py36_np15 succeeded
Details
pandas-dev.pandas (Windows py37_np141) Windows py37_np141 succeeded
Details
pandas-dev.pandas (macOS py35_macos) macOS py35_macos succeeded
Details

alimcmaster1 added a commit to alimcmaster1/pandas that referenced this pull request Jun 30, 2019

CLN/PERF: remove gc.collect from the setting_with_copy checks as not …
…needed (pandas-dev#27031)

* CLN/PERF: remove gc.collect from the setting_with_copy checks as not needed

* fixup whatsnew

* add asv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.