-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: regression on master in groupby agg with ExtensionArray #29141
Comments
Pretty strange. I don't see it in the traceback of the logs but I assume that comes from here: pandas/pandas/_libs/reduction.pyx Line 53 in 6c898e6
|
I expect this is solved by #29100 |
It seems to solve the Decimal example, but not fully the GeoPandas one. The result is still object dtype, while before it was geometry dtype |
Two ideas, not mutually exclusive:
|
So for the geopandas case, I didn't post the reproducer yet (I was trying to find one with Decimal), but it is:
(the above is master from a few days ago, where the result has 'geometry' dtype) |
And (somewhat artificial) reproducer with Decimal:
|
Example that I could make with DecimalArray:
On master of a few days ago, the above returned 'decimal' dtype instead of object dtype.
Found this in the geopandas test suite, as there it creates invalid output and then an error in a follow-up operation (https://travis-ci.org/geopandas/geopandas/jobs/600859374)
This seems to be caused by #29088, and specifically the change in
agg_series
: https://github.com/pandas-dev/pandas/pull/29088/files#diff-8c0985a9fca770c2028bed688dfc043fR653-R666The
self._aggregate_series_fast
is giving a "AttributeError: 'DecimalArray' object has no attribute 'flags'" error if the series is backed by an EA, and the AttributeError is no longer catched.cc @jbrockmendel
The text was updated successfully, but these errors were encountered: