API: drop kwargs from Series.dropna, add explicit how parameter
#29388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
tighten_series_dropna_signature
branch
from
2547739
to
0de5a25
Compare
jreback
reviewed
Nov 3, 2019
| @@ -4608,7 +4608,7 @@ def dropna(self, axis=0, inplace=False, **kwargs): | |||
| There is only one axis to drop values from. | |||
| inplace : bool, default False | |||
| If True, do operation inplace and return None. | |||
| **kwargs | |||
| how : str, optional | |||
There was a problem hiding this comment.
maybe mention this is for compatibility
topper-123
force-pushed
the
tighten_series_dropna_signature
branch
from
0de5a25
to
77461fd
Compare
topper-123
force-pushed
the
tighten_series_dropna_signature
branch
from
77461fd
to
a85ef2a
Compare
topper-123
force-pushed
the
tighten_series_dropna_signature
branch
from
a85ef2a
to
8a45957
Compare
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
**kwargsgave false type hints on what the dropna method could take for arguments, and supplying anything buthowraised a TypeError already.