Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timedeltas: Understand µs #32899

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Timedeltas: Understand µs #32899

merged 1 commit into from
Mar 24, 2020

Conversation

alvaroaleman
Copy link
Contributor

@alvaroaleman alvaroaleman commented Mar 22, 2020 •
edited
Loading

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

These are emitted by golangs time.Duration printing: https://github.com/golang/go/blob/36b815edd6cd23d5aabdb488c24db2033bbdeea2/src/time/time.go#L669

jreback
jreback requested changes Mar 22, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add a test & a what’s new note (other enhancements)

is this fixing a specific issue?

@alvaroaleman
Copy link
Contributor Author

pls add a test & a what’s new note (other enhancements)

Done

is this fixing a specific issue?

Yes, this is fixing the "Pandas can not parse golang duration strings if they contain microseconds" issue.

@jreback
Copy link
Contributor

jreback commented Mar 22, 2020

what i mean is do we already have an open issue for what this is fixing?

@alvaroaleman
Copy link
Contributor Author

what i mean is do we already have an open issue for what this is fixing?

No, want me to open one and add a closes directive to the PR?

@alvaroaleman
Copy link
Contributor Author

@jreback The CI / Checks (pull_request) failed with a HTTPError: HTTP Error 503: Backend fetch failed. That's not from the PRs changes I guess? Can you restart it or do I need to force push?

@jreback
Copy link
Contributor

jreback commented Mar 22, 2020

no don’t open an issue

@ShaharNaveh
Copy link
Member

@alvaroaleman Can you please rebase? the CI is failing due to an issue we recently resolved, merging master should solve this.

@alvaroaleman
Copy link
Contributor Author

@MomIsBestFriend done, all checks are green now :)

@alvaroaleman alvaroaleman mentioned this pull request Mar 22, 2020
Merged
@jreback jreback added the Timedelta Timedelta data type label Mar 22, 2020
jreback
jreback requested changes Mar 22, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, ping on green.

doc/source/whatsnew/v1.1.0.rst Outdated
@@ -407,6 +407,7 @@ Other
- Fixed bug in :func:`pandas.testing.assert_series_equal` where dtypes were checked for ``Interval`` and ``ExtensionArray`` operands when ``check_dtype`` was ``False`` (:issue:`32747`)
- Bug in :meth:`Series.map` not raising on invalid ``na_action`` (:issue:`32815`)
- Bug in :meth:`DataFrame.__dir__` caused a segfault when using unicode surrogates in a column name (:issue:`25509`)
- Timedeltas now understand µs as identifier for microsecond (:issue:`32899`)
Copy link
Contributor

@jreback jreback Mar 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move tot he timedelta section in bug fixes (i know i said this section before, but we are trying to limit what is here), put us in double-backticks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jreback Done and all checks are green again

@jreback jreback added this to the 1.1 milestone Mar 22, 2020
@jreback jreback added the Bug label Mar 22, 2020
@jreback jreback merged commit 3e247fa into pandas-dev:master Mar 24, 2020
@jreback
Copy link
Contributor

jreback commented Mar 24, 2020

thanks @alvaroaleman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Bug Timedelta Timedelta data type
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alvaroaleman @jreback @ShaharNaveh