Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: de-duplicate get_indexer methods #38372

Merged
merged 9 commits into from Dec 11, 2020
Merged

REF: de-duplicate get_indexer methods #38372

merged 9 commits into from Dec 11, 2020

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Sits on top of #38308

jreback
jreback approved these changes Dec 11, 2020
View reviewed changes
pandas/core/indexes/base.py
@@ -3199,6 +3199,24 @@ def _get_indexer(

return ensure_platform_int(indexer)

def _check_indexing_method(self, method):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type at some point

@jreback jreback added Index Related to the Index class or subclasses Indexing Related to indexing on series/frames, not to indexes themselves Refactor Internal refactoring of code labels Dec 11, 2020
@jreback jreback added this to the 1.3 milestone Dec 11, 2020
@jreback jreback merged commit 5a7514c into pandas-dev:master Dec 11, 2020
@jbrockmendel jbrockmendel deleted the ref-get_indexer-2 branch December 11, 2020 22:58
@mroeschke mroeschke mentioned this pull request Dec 14, 2020
Merged
5 tasks
@simonjayhawkins simonjayhawkins mentioned this pull request Dec 18, 2020
Closed
3 tasks
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@jbrockmendel @luckyvs1
REF: de-duplicate get_indexer methods (pandas-dev#38372)
255bc29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Index Related to the Index class or subclasses Indexing Related to indexing on series/frames, not to indexes themselves Refactor Internal refactoring of code
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbrockmendel @jreback