Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove numpy pin from environment.yml on 1.2.x #39998

Conversation

simonjayhawkins
Copy link
Member

xref #39513, expected to fail until #39994 backported

This PR is directly against 1.2.x and ignores site packages for mypy checks.

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Feb 23, 2021
@simonjayhawkins simonjayhawkins added this to the 1.2.3 milestone Feb 23, 2021
@simonjayhawkins
Copy link
Member Author

can remove blocker label from #39513 on merge, #39513 (comment)

@simonjayhawkins
Copy link
Member Author

expected to fail until #39994 backported

the problematic benchmark is only on master

@jreback
Copy link
Contributor

jreback commented Feb 26, 2021

lgtm. @simonjayhawkins merge when ready

@simonjayhawkins simonjayhawkins merged commit 3667165 into pandas-dev:1.2.x Feb 26, 2021
@simonjayhawkins simonjayhawkins deleted the remove-numpy-pin-from-environment.yml-on-1.2.x branch February 26, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants