ENH: Styler.highlight_quantile method
#40926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
attack68
commented
Apr 13, 2021
•
attack68
commented
# Conflicts: # pandas/io/formats/style.py
attack68
changed the title
Styler.highlight_quantile methodStyler.highlight_quantile method
jreback
requested changes
Apr 16, 2021
pandas/io/formats/style.py
Outdated
| axis, axis_apply = 1, 0 | ||
| else: | ||
| axis, axis_apply = None, None | ||
| q = np.nanquantile( |
There was a problem hiding this comment.
is there a reason you are not using Series.quantile? (which does handle timetamp and other types).
There was a problem hiding this comment.
previously I was using qcut which was criticised, probably for good reason, so I switched to NumPy, to be honest didn't see these when searching.
However, numpy allows axis=None, whereas to achieve the same result here I will need to ravel a DataFrame to a Series and apply the calculation. Still, I will give it a try.
jreback
approved these changes
Apr 20, 2021
|
thanks @attack68 |
yeshsurya
pushed a commit
to yeshsurya/pandas
that referenced
this pull request
Apr 21, 2021
yeshsurya
pushed a commit
to yeshsurya/pandas
that referenced
this pull request
May 6, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.